Commit 0906e20f authored by Al Viro's avatar Al Viro Committed by David S. Miller

[SCTP] bug: sctp_assoc_control_transport() breakage

a) struct sockaddr_storage * passed to sctp_ulpevent_make_peer_addr_change()
actually points at union sctp_addr field in a structure.  Then that sucker
gets copied to userland, with whatever junk we might have there.

b) it's actually having host-endian sin_port.
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d5c747f6
...@@ -709,6 +709,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, ...@@ -709,6 +709,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
struct sctp_transport *first; struct sctp_transport *first;
struct sctp_transport *second; struct sctp_transport *second;
struct sctp_ulpevent *event; struct sctp_ulpevent *event;
struct sockaddr_storage addr;
struct list_head *pos; struct list_head *pos;
int spc_state = 0; int spc_state = 0;
...@@ -731,8 +732,9 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, ...@@ -731,8 +732,9 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
/* Generate and send a SCTP_PEER_ADDR_CHANGE notification to the /* Generate and send a SCTP_PEER_ADDR_CHANGE notification to the
* user. * user.
*/ */
event = sctp_ulpevent_make_peer_addr_change(asoc, memset(&addr, 0, sizeof(struct sockaddr_storage));
(struct sockaddr_storage *) &transport->ipaddr, flip_to_n((union sctp_addr *)&addr, &transport->ipaddr);
event = sctp_ulpevent_make_peer_addr_change(asoc, &addr,
0, spc_state, error, GFP_ATOMIC); 0, spc_state, error, GFP_ATOMIC);
if (event) if (event)
sctp_ulpq_tail_event(&asoc->ulpq, event); sctp_ulpq_tail_event(&asoc->ulpq, event);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment