Commit 09185e27 authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Herbert Xu

hwrng: xgene - fix handling platform_get_irq

The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 17762c5a
...@@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev) ...@@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev)
if (IS_ERR(ctx->csr_base)) if (IS_ERR(ctx->csr_base))
return PTR_ERR(ctx->csr_base); return PTR_ERR(ctx->csr_base);
ctx->irq = platform_get_irq(pdev, 0); rc = platform_get_irq(pdev, 0);
if (ctx->irq < 0) { if (rc < 0) {
dev_err(&pdev->dev, "No IRQ resource\n"); dev_err(&pdev->dev, "No IRQ resource\n");
return ctx->irq; return rc;
} }
ctx->irq = rc;
dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d", dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
ctx->csr_base, ctx->irq); ctx->csr_base, ctx->irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment