Commit 09ae6345 authored by Christoph Paasch's avatar Christoph Paasch Committed by Mimi Zohar

ima: Do not free 'entry' before it is initialized

7bc5f447 (ima: define new function ima_alloc_init_template() to
API) moved the initialization of 'entry' in ima_add_boot_aggregate() a
bit more below, after the if (ima_used_chip).

So, 'entry' is not initialized while being inside this if-block. So, we
should not attempt to free it.

Found by Coverity (CID: 1131971)

Fixes: 7bc5f447 (ima: define new function ima_alloc_init_template() to API)
Signed-off-by: default avatarChristoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: default avatarMimi Zohar <zohar@us.ibm.com>
parent a45299e7
...@@ -63,7 +63,6 @@ static void __init ima_add_boot_aggregate(void) ...@@ -63,7 +63,6 @@ static void __init ima_add_boot_aggregate(void)
result = ima_calc_boot_aggregate(&hash.hdr); result = ima_calc_boot_aggregate(&hash.hdr);
if (result < 0) { if (result < 0) {
audit_cause = "hashing_error"; audit_cause = "hashing_error";
kfree(entry);
goto err_out; goto err_out;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment