Commit 09f20f2b authored by Bingbu Cao's avatar Bingbu Cao Committed by Mauro Carvalho Chehab

media: intel-ipu3: cio2: Handle IRQs until INT_STS is cleared

Interrupt behavior shows that some time the frame end and frame start of
next frame is unstable and can range from several to hundreds of
micro-sec. In the case of ~10us, isr may not clear next sof interrupt
status in single handling, which prevents new interrupts from coming.

Fix this by handling all pending IRQs before exiting isr, so any abnormal
behavior results from very short interrupt status changes is protected.
Signed-off-by: default avatarBingbu Cao <bingbu.cao@intel.com>
Signed-off-by: default avatarAndy Yeh <andy.yeh@intel.com>
Signed-off-by: default avatarYong Zhi <yong.zhi@intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent f10379aa
......@@ -640,18 +640,10 @@ static const char *const cio2_port_errs[] = {
"PKT2LONG",
};
static irqreturn_t cio2_irq(int irq, void *cio2_ptr)
static void cio2_irq_handle_once(struct cio2_device *cio2, u32 int_status)
{
struct cio2_device *cio2 = cio2_ptr;
void __iomem *const base = cio2->base;
struct device *dev = &cio2->pci_dev->dev;
u32 int_status, int_clear;
int_status = readl(base + CIO2_REG_INT_STS);
int_clear = int_status;
if (!int_status)
return IRQ_NONE;
if (int_status & CIO2_INT_IOOE) {
/*
......@@ -770,9 +762,29 @@ static irqreturn_t cio2_irq(int irq, void *cio2_ptr)
int_status &= ~(CIO2_INT_IOIE | CIO2_INT_IOIRQ);
}
writel(int_clear, base + CIO2_REG_INT_STS);
if (int_status)
dev_warn(dev, "unknown interrupt 0x%x on INT\n", int_status);
}
static irqreturn_t cio2_irq(int irq, void *cio2_ptr)
{
struct cio2_device *cio2 = cio2_ptr;
void __iomem *const base = cio2->base;
struct device *dev = &cio2->pci_dev->dev;
u32 int_status;
int_status = readl(base + CIO2_REG_INT_STS);
dev_dbg(dev, "isr enter - interrupt status 0x%x\n", int_status);
if (!int_status)
return IRQ_NONE;
do {
writel(int_status, base + CIO2_REG_INT_STS);
cio2_irq_handle_once(cio2, int_status);
int_status = readl(base + CIO2_REG_INT_STS);
if (int_status)
dev_dbg(dev, "pending status 0x%x\n", int_status);
} while (int_status);
return IRQ_HANDLED;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment