Commit 0ac72f90 authored by Bjorn Andersson's avatar Bjorn Andersson

remoteproc: sysmon: Improve error messages

Improve the style of a few of the error messages printed by the sysmon
implementation and fix the copy-pasted shutdown error in the send-event
function.
Tested-by: default avatarSteev Klimaszewski <steev@kali.org>
Reviewed-by: default avatarRishabh Bhatnagar <rishabhb@codeaurora.org>
Link: https://lore.kernel.org/r/20201122054135.802935-5-bjorn.andersson@linaro.orgSigned-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent ed5da808
...@@ -352,9 +352,9 @@ static bool ssctl_request_shutdown(struct qcom_sysmon *sysmon) ...@@ -352,9 +352,9 @@ static bool ssctl_request_shutdown(struct qcom_sysmon *sysmon)
ret = qmi_txn_wait(&txn, 5 * HZ); ret = qmi_txn_wait(&txn, 5 * HZ);
if (ret < 0) { if (ret < 0) {
dev_err(sysmon->dev, "failed receiving QMI response\n"); dev_err(sysmon->dev, "timeout waiting for shutdown response\n");
} else if (resp.resp.result) { } else if (resp.resp.result) {
dev_err(sysmon->dev, "shutdown request failed\n"); dev_err(sysmon->dev, "shutdown request rejected\n");
} else { } else {
dev_dbg(sysmon->dev, "shutdown request completed\n"); dev_dbg(sysmon->dev, "shutdown request completed\n");
acked = true; acked = true;
...@@ -397,18 +397,18 @@ static void ssctl_send_event(struct qcom_sysmon *sysmon, ...@@ -397,18 +397,18 @@ static void ssctl_send_event(struct qcom_sysmon *sysmon,
SSCTL_SUBSYS_EVENT_REQ, 40, SSCTL_SUBSYS_EVENT_REQ, 40,
ssctl_subsys_event_req_ei, &req); ssctl_subsys_event_req_ei, &req);
if (ret < 0) { if (ret < 0) {
dev_err(sysmon->dev, "failed to send shutdown request\n"); dev_err(sysmon->dev, "failed to send subsystem event\n");
qmi_txn_cancel(&txn); qmi_txn_cancel(&txn);
return; return;
} }
ret = qmi_txn_wait(&txn, 5 * HZ); ret = qmi_txn_wait(&txn, 5 * HZ);
if (ret < 0) if (ret < 0)
dev_err(sysmon->dev, "failed receiving QMI response\n"); dev_err(sysmon->dev, "timeout waiting for subsystem event response\n");
else if (resp.resp.result) else if (resp.resp.result)
dev_err(sysmon->dev, "ssr event send failed\n"); dev_err(sysmon->dev, "subsystem event rejected\n");
else else
dev_dbg(sysmon->dev, "ssr event send completed\n"); dev_dbg(sysmon->dev, "subsystem event accepted\n");
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment