Commit 0aeccdfe authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: scsi_dh_alua: Warn if the first argument of alua_rtpg_queue() is NULL

Callers must provide a valid port group to alua_rtpg_queue().  Issue a
kernel warning if that is not the case.
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Tang Junhui <tang.junhui@zte.com.cn>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7cb689fe
...@@ -876,7 +876,7 @@ static bool alua_rtpg_queue(struct alua_port_group *pg, ...@@ -876,7 +876,7 @@ static bool alua_rtpg_queue(struct alua_port_group *pg,
unsigned long flags; unsigned long flags;
struct workqueue_struct *alua_wq = kaluad_wq; struct workqueue_struct *alua_wq = kaluad_wq;
if (!pg || scsi_device_get(sdev)) if (WARN_ON_ONCE(!pg) || scsi_device_get(sdev))
return false; return false;
spin_lock_irqsave(&pg->lock, flags); spin_lock_irqsave(&pg->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment