Commit 0afd6a4e authored by Michael Chan's avatar Michael Chan Committed by David S. Miller

bnxt_en: Rediscover PHY capabilities after firmware reset

There is a missing bnxt_probe_phy() call in bnxt_fw_init_one() to
rediscover the PHY capabilities after a firmware reset.  This can cause
some PHY related functionalities to fail after a firmware reset.  For
example, in multi-host, the ability for any host to configure the PHY
settings may be lost after a firmware reset.

Fixes: ec5d31e3 ("bnxt_en: Handle firmware reset status during IF_UP.")
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 39eb0281
...@@ -11750,6 +11750,8 @@ static void bnxt_fw_init_one_p3(struct bnxt *bp) ...@@ -11750,6 +11750,8 @@ static void bnxt_fw_init_one_p3(struct bnxt *bp)
bnxt_hwrm_coal_params_qcaps(bp); bnxt_hwrm_coal_params_qcaps(bp);
} }
static int bnxt_probe_phy(struct bnxt *bp, bool fw_dflt);
static int bnxt_fw_init_one(struct bnxt *bp) static int bnxt_fw_init_one(struct bnxt *bp)
{ {
int rc; int rc;
...@@ -11764,6 +11766,9 @@ static int bnxt_fw_init_one(struct bnxt *bp) ...@@ -11764,6 +11766,9 @@ static int bnxt_fw_init_one(struct bnxt *bp)
netdev_err(bp->dev, "Firmware init phase 2 failed\n"); netdev_err(bp->dev, "Firmware init phase 2 failed\n");
return rc; return rc;
} }
rc = bnxt_probe_phy(bp, false);
if (rc)
return rc;
rc = bnxt_approve_mac(bp, bp->dev->dev_addr, false); rc = bnxt_approve_mac(bp, bp->dev->dev_addr, false);
if (rc) if (rc)
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment