Commit 0afec568 authored by Rusty Russell's avatar Rusty Russell Committed by Linus Torvalds

[PATCH] Catch module parameter parsing failures

Radheka Godse <radheka.godse@intel.com> pointed out that parameter parsing
failures allow a module still to be loaded.  Trivial fix.
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent bf36f91f
......@@ -1691,6 +1691,9 @@ static struct module *load_module(void __user *umod,
/ sizeof(struct kernel_param),
NULL);
}
if (err < 0)
goto arch_cleanup;
err = mod_sysfs_setup(mod,
(struct kernel_param *)
sechdrs[setupindex].sh_addr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment