Commit 0b2c605f authored by Borislav Petkov's avatar Borislav Petkov

x86/entry/64: Correct the comment over SAVE_AND_SET_GSBASE

Add the proper explanation why an LFENCE is not needed in the FSGSBASE
case.

Fixes: c82965f9 ("x86/entry/64: Handle FSGSBASE enabled paranoid entry/exit")
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200821090710.GE12181@zn.tnic
parent d012a719
...@@ -840,8 +840,9 @@ SYM_CODE_START_LOCAL(paranoid_entry) ...@@ -840,8 +840,9 @@ SYM_CODE_START_LOCAL(paranoid_entry)
* retrieve and set the current CPUs kernel GSBASE. The stored value * retrieve and set the current CPUs kernel GSBASE. The stored value
* has to be restored in paranoid_exit unconditionally. * has to be restored in paranoid_exit unconditionally.
* *
* The MSR write ensures that no subsequent load is based on a * The unconditional write to GS base below ensures that no subsequent
* mispredicted GSBASE. No extra FENCE required. * loads based on a mispredicted GS base can happen, therefore no LFENCE
* is needed here.
*/ */
SAVE_AND_SET_GSBASE scratch_reg=%rax save_reg=%rbx SAVE_AND_SET_GSBASE scratch_reg=%rax save_reg=%rbx
ret ret
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment