Commit 0b7ac8e4 authored by Greg Ungerer's avatar Greg Ungerer Committed by Linus Torvalds

[PATCH] m68knommu: read/write register access for ColdFire core timer

Modify the m68knommu/ColdFire core timer code to use register offsets
with raw_read/raw_write access, instead of a mapped struct.
Signed-off-by: default avatarGreg Ungerer <gerg@uclinux.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent c88b36e2
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include <linux/param.h> #include <linux/param.h>
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/init.h> #include <linux/init.h>
#include <asm/io.h>
#include <asm/irq.h> #include <asm/irq.h>
#include <asm/traps.h> #include <asm/traps.h>
#include <asm/machdep.h> #include <asm/machdep.h>
...@@ -23,6 +24,11 @@ ...@@ -23,6 +24,11 @@
/***************************************************************************/ /***************************************************************************/
/*
* By default use timer1 as the system clock timer.
*/
#define TA(a) (MCF_MBAR + MCFTIMER_BASE1 + (a))
/* /*
* Default the timer and vector to use for ColdFire. Some ColdFire * Default the timer and vector to use for ColdFire. Some ColdFire
* CPU's and some boards may want different. Their sub-architecture * CPU's and some boards may want different. Their sub-architecture
...@@ -32,8 +38,6 @@ unsigned int mcf_timervector = 29; ...@@ -32,8 +38,6 @@ unsigned int mcf_timervector = 29;
unsigned int mcf_profilevector = 31; unsigned int mcf_profilevector = 31;
unsigned int mcf_timerlevel = 5; unsigned int mcf_timerlevel = 5;
static volatile struct mcftimer *mcf_timerp;
/* /*
* These provide the underlying interrupt vector support. * These provide the underlying interrupt vector support.
* Unfortunately it is a little different on each ColdFire. * Unfortunately it is a little different on each ColdFire.
...@@ -46,20 +50,17 @@ extern int mcf_timerirqpending(int timer); ...@@ -46,20 +50,17 @@ extern int mcf_timerirqpending(int timer);
void coldfire_tick(void) void coldfire_tick(void)
{ {
/* Reset the ColdFire timer */ /* Reset the ColdFire timer */
mcf_timerp->ter = MCFTIMER_TER_CAP | MCFTIMER_TER_REF; __raw_writeb(MCFTIMER_TER_CAP | MCFTIMER_TER_REF, TA(MCFTIMER_TER));
} }
/***************************************************************************/ /***************************************************************************/
void coldfire_timer_init(irqreturn_t (*handler)(int, void *, struct pt_regs *)) void coldfire_timer_init(irqreturn_t (*handler)(int, void *, struct pt_regs *))
{ {
/* Set up an internal TIMER as poll clock */ __raw_writew(MCFTIMER_TMR_DISABLE, TA(MCFTIMER_TMR));
mcf_timerp = (volatile struct mcftimer *) (MCF_MBAR + MCFTIMER_BASE1); __raw_writew(((MCF_BUSCLK / 16) / HZ), TA(MCFTIMER_TRR));
mcf_timerp->tmr = MCFTIMER_TMR_DISABLE; __raw_writew(MCFTIMER_TMR_ENORI | MCFTIMER_TMR_CLK16 |
MCFTIMER_TMR_RESTART | MCFTIMER_TMR_ENABLE, TA(MCFTIMER_TMR));
mcf_timerp->trr = (unsigned short) ((MCF_BUSCLK / 16) / HZ);
mcf_timerp->tmr = MCFTIMER_TMR_ENORI | MCFTIMER_TMR_CLK16 |
MCFTIMER_TMR_RESTART | MCFTIMER_TMR_ENABLE;
request_irq(mcf_timervector, handler, SA_INTERRUPT, "timer", NULL); request_irq(mcf_timervector, handler, SA_INTERRUPT, "timer", NULL);
mcf_settimericr(1, mcf_timerlevel); mcf_settimericr(1, mcf_timerlevel);
...@@ -75,13 +76,8 @@ unsigned long coldfire_timer_offset(void) ...@@ -75,13 +76,8 @@ unsigned long coldfire_timer_offset(void)
{ {
unsigned long trr, tcn, offset; unsigned long trr, tcn, offset;
/* tcn = __raw_readw(TA(MCFTIMER_TCN));
* The change to pointer and de-reference is to force the compiler trr = __raw_readw(TA(MCFTIMER_TRR));
* to read the registers with a single 16bit access. Otherwise it
* does some crazy 8bit read combining.
*/
tcn = *(&mcf_timerp->tcn);
trr = *(&mcf_timerp->trr);
offset = (tcn * (1000000 / HZ)) / trr; offset = (tcn * (1000000 / HZ)) / trr;
/* Check if we just wrapped the counters and maybe missed a tick */ /* Check if we just wrapped the counters and maybe missed a tick */
...@@ -94,22 +90,24 @@ unsigned long coldfire_timer_offset(void) ...@@ -94,22 +90,24 @@ unsigned long coldfire_timer_offset(void)
#ifdef CONFIG_HIGHPROFILE #ifdef CONFIG_HIGHPROFILE
/***************************************************************************/ /***************************************************************************/
/*
* By default use timer2 as the profiler clock timer.
*/
#define PA(a) (MCF_MBAR + MCFTIMER_BASE2 + (a))
/* /*
* Choose a reasonably fast profile timer. Make it an odd value to * Choose a reasonably fast profile timer. Make it an odd value to
* try and get good coverage of kernal operations. * try and get good coverage of kernal operations.
*/ */
#define PROFILEHZ 1013 #define PROFILEHZ 1013
static volatile struct mcftimer *mcf_proftp;
/* /*
* Use the other timer to provide high accuracy profiling info. * Use the other timer to provide high accuracy profiling info.
*/ */
void coldfire_profile_tick(int irq, void *dummy, struct pt_regs *regs) void coldfire_profile_tick(int irq, void *dummy, struct pt_regs *regs)
{ {
/* Reset ColdFire timer2 */ /* Reset ColdFire timer2 */
mcf_proftp->ter = MCFTIMER_TER_CAP | MCFTIMER_TER_REF; __raw_writeb(MCFTIMER_TER_CAP | MCFTIMER_TER_REF, PA(MCFTIMER_TER));
if (current->pid) if (current->pid)
profile_tick(CPU_PROFILING, regs); profile_tick(CPU_PROFILING, regs);
} }
...@@ -121,12 +119,11 @@ void coldfire_profile_init(void) ...@@ -121,12 +119,11 @@ void coldfire_profile_init(void)
printk(KERN_INFO "PROFILE: lodging TIMER2 @ %dHz as profile timer\n", PROFILEHZ); printk(KERN_INFO "PROFILE: lodging TIMER2 @ %dHz as profile timer\n", PROFILEHZ);
/* Set up TIMER 2 as high speed profile clock */ /* Set up TIMER 2 as high speed profile clock */
mcf_proftp = (volatile struct mcftimer *) (MCF_MBAR + MCFTIMER_BASE2); __raw_writew(MCFTIMER_TMR_DISABLE, PA(MCFTIMER_TMR));
mcf_proftp->tmr = MCFTIMER_TMR_DISABLE;
mcf_proftp->trr = (unsigned short) ((MCF_CLK / 16) / PROFILEHZ); __raw_writew(((MCF_CLK / 16) / PROFILEHZ), PA(MCFTIMER_TRR));
mcf_proftp->tmr = MCFTIMER_TMR_ENORI | MCFTIMER_TMR_CLK16 | __raw_writew(MCFTIMER_TMR_ENORI | MCFTIMER_TMR_CLK16 |
MCFTIMER_TMR_RESTART | MCFTIMER_TMR_ENABLE; MCFTIMER_TMR_RESTART | MCFTIMER_TMR_ENABLE, PA(MCFTIMER_TMR));
request_irq(mcf_profilevector, coldfire_profile_tick, request_irq(mcf_profilevector, coldfire_profile_tick,
(SA_INTERRUPT | IRQ_FLG_FAST), "profile timer", NULL); (SA_INTERRUPT | IRQ_FLG_FAST), "profile timer", NULL);
......
...@@ -3,7 +3,7 @@ ...@@ -3,7 +3,7 @@
/* /*
* mcftimer.h -- ColdFire internal TIMER support defines. * mcftimer.h -- ColdFire internal TIMER support defines.
* *
* (C) Copyright 1999-2002, Greg Ungerer (gerg@snapgear.com) * (C) Copyright 1999-2006, Greg Ungerer <gerg@snapgear.com>
* (C) Copyright 2000, Lineo Inc. (www.lineo.com) * (C) Copyright 2000, Lineo Inc. (www.lineo.com)
*/ */
...@@ -27,6 +27,11 @@ ...@@ -27,6 +27,11 @@
#elif defined(CONFIG_M5249) || defined(CONFIG_M5307) || defined(CONFIG_M5407) #elif defined(CONFIG_M5249) || defined(CONFIG_M5307) || defined(CONFIG_M5407)
#define MCFTIMER_BASE1 0x140 /* Base address of TIMER1 */ #define MCFTIMER_BASE1 0x140 /* Base address of TIMER1 */
#define MCFTIMER_BASE2 0x180 /* Base address of TIMER2 */ #define MCFTIMER_BASE2 0x180 /* Base address of TIMER2 */
#elif defined(CONFIG_M532x)
#define MCFTIMER_BASE1 0xfc070000 /* Base address of TIMER1 */
#define MCFTIMER_BASE2 0xfc074000 /* Base address of TIMER2 */
#define MCFTIMER_BASE3 0xfc078000 /* Base address of TIMER3 */
#define MCFTIMER_BASE4 0xfc07c000 /* Base address of TIMER4 */
#endif #endif
...@@ -34,23 +39,14 @@ ...@@ -34,23 +39,14 @@
* Define the TIMER register set addresses. * Define the TIMER register set addresses.
*/ */
#define MCFTIMER_TMR 0x00 /* Timer Mode reg (r/w) */ #define MCFTIMER_TMR 0x00 /* Timer Mode reg (r/w) */
#define MCFTIMER_TRR 0x02 /* Timer Reference (r/w) */ #define MCFTIMER_TRR 0x04 /* Timer Reference (r/w) */
#define MCFTIMER_TCR 0x04 /* Timer Capture reg (r/w) */ #define MCFTIMER_TCR 0x08 /* Timer Capture reg (r/w) */
#define MCFTIMER_TCN 0x06 /* Timer Counter reg (r/w) */ #define MCFTIMER_TCN 0x0C /* Timer Counter reg (r/w) */
#if defined(CONFIG_M532x)
#define MCFTIMER_TER 0x03 /* Timer Event reg (r/w) */
#else
#define MCFTIMER_TER 0x11 /* Timer Event reg (r/w) */ #define MCFTIMER_TER 0x11 /* Timer Event reg (r/w) */
#endif
struct mcftimer {
unsigned short tmr; /* Timer Mode reg (r/w) */
unsigned short reserved1;
unsigned short trr; /* Timer Reference (r/w) */
unsigned short reserved2;
unsigned short tcr; /* Timer Capture reg (r/w) */
unsigned short reserved3;
unsigned short tcn; /* Timer Counter reg (r/w) */
unsigned short reserved4;
unsigned char reserved5;
unsigned char ter; /* Timer Event reg (r/w) */
} __attribute__((packed));
/* /*
* Bit definitions for the Timer Mode Register (TMR). * Bit definitions for the Timer Mode Register (TMR).
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment