Commit 0b7d25c3 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Thierry Reding

pwm: lp3943: Fix potential memory leak during request

Fix a memory leak in the lp3943_pwm_request_map() error handling path.
Make sure already allocated pwm map memory is freed correctly.
Detected by Coverity: CID 1162829.
Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Acked-by: default avatarMilo Kim <milo.kim@ti.com>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 38dbfb59
...@@ -52,8 +52,10 @@ lp3943_pwm_request_map(struct lp3943_pwm *lp3943_pwm, int hwpwm) ...@@ -52,8 +52,10 @@ lp3943_pwm_request_map(struct lp3943_pwm *lp3943_pwm, int hwpwm)
offset = pwm_map->output[i]; offset = pwm_map->output[i];
/* Return an error if the pin is already assigned */ /* Return an error if the pin is already assigned */
if (test_and_set_bit(offset, &lp3943->pin_used)) if (test_and_set_bit(offset, &lp3943->pin_used)) {
kfree(pwm_map);
return ERR_PTR(-EBUSY); return ERR_PTR(-EBUSY);
}
} }
return pwm_map; return pwm_map;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment