Commit 0bc825d2 authored by Rakib Mullick's avatar Rakib Mullick Committed by Linus Torvalds

codafs: fix compile warning when CONFIG_SYSCTL=n

When CONFIG_SYSCTL=n, we get the following warning:

fs/coda/sysctl.c:18: warning: `coda_tabl' defined but not used

Fix the warning by making sure coda_table and it's callee function are in
the same context.  Also clean up the code by removing extra #ifdef.

[akpm@linux-foundation.org: remove unneeded stub macros]
Signed-off-by: default avatarRakib Mullick <rakib.mullick@gmail.com>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1c00f016
...@@ -13,7 +13,6 @@ ...@@ -13,7 +13,6 @@
#ifdef CONFIG_SYSCTL #ifdef CONFIG_SYSCTL
static struct ctl_table_header *fs_table_header; static struct ctl_table_header *fs_table_header;
#endif
static ctl_table coda_table[] = { static ctl_table coda_table[] = {
{ {
...@@ -40,7 +39,6 @@ static ctl_table coda_table[] = { ...@@ -40,7 +39,6 @@ static ctl_table coda_table[] = {
{} {}
}; };
#ifdef CONFIG_SYSCTL
static ctl_table fs_table[] = { static ctl_table fs_table[] = {
{ {
.procname = "coda", .procname = "coda",
...@@ -49,22 +47,18 @@ static ctl_table fs_table[] = { ...@@ -49,22 +47,18 @@ static ctl_table fs_table[] = {
}, },
{} {}
}; };
#endif
void coda_sysctl_init(void) void coda_sysctl_init(void)
{ {
#ifdef CONFIG_SYSCTL
if ( !fs_table_header ) if ( !fs_table_header )
fs_table_header = register_sysctl_table(fs_table); fs_table_header = register_sysctl_table(fs_table);
#endif
} }
void coda_sysctl_clean(void) void coda_sysctl_clean(void)
{ {
#ifdef CONFIG_SYSCTL
if ( fs_table_header ) { if ( fs_table_header ) {
unregister_sysctl_table(fs_table_header); unregister_sysctl_table(fs_table_header);
fs_table_header = NULL; fs_table_header = NULL;
} }
#endif
} }
#endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment