Commit 0c0a5883 authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown

ASoC: codecs: lpass-rx-macro: Fix uninitialized variable ec_tx

There is potential read of the uninitialized variable ec_tx if the call
to snd_soc_component_read fails or returns an unrecognized w->name. To
avoid this corner case, initialize ec_tx to -1 so that it is caught
later when ec_tx is bounds checked.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 4f692926 ("ASoC: codecs: lpass-rx-macro: add dapm widgets and route")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210215163313.84026-1-colin.king@canonical.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 0d2b6e39
...@@ -2895,7 +2895,7 @@ static int rx_macro_enable_echo(struct snd_soc_dapm_widget *w, ...@@ -2895,7 +2895,7 @@ static int rx_macro_enable_echo(struct snd_soc_dapm_widget *w,
{ {
struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
u16 val, ec_hq_reg; u16 val, ec_hq_reg;
int ec_tx; int ec_tx = -1;
val = snd_soc_component_read(component, val = snd_soc_component_read(component,
CDC_RX_INP_MUX_RX_MIX_CFG4); CDC_RX_INP_MUX_RX_MIX_CFG4);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment