Commit 0cba5c34 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller

net/sched: matchall: Avoid overwriting error messages

The various error paths of tc_setup_offload_action() now report specific
error messages. Remove the generic messages to avoid overwriting the
more specific ones.

Before:

 # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000
 Error: cls_matchall: Failed to setup flow action.
 We have an error talking to the kernel

After:

 # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000
 Error: act_police: Offload not supported when conform/exceed action is "reclassify".
 We have an error talking to the kernel
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c440615f
...@@ -102,8 +102,6 @@ static int mall_replace_hw_filter(struct tcf_proto *tp, ...@@ -102,8 +102,6 @@ static int mall_replace_hw_filter(struct tcf_proto *tp,
if (err) { if (err) {
kfree(cls_mall.rule); kfree(cls_mall.rule);
mall_destroy_hw_filter(tp, head, cookie, NULL); mall_destroy_hw_filter(tp, head, cookie, NULL);
NL_SET_ERR_MSG_MOD(cls_mall.common.extack,
"Failed to setup flow action");
return skip_sw ? err : 0; return skip_sw ? err : 0;
} }
...@@ -305,8 +303,6 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, ...@@ -305,8 +303,6 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb,
cls_mall.common.extack); cls_mall.common.extack);
if (err) { if (err) {
kfree(cls_mall.rule); kfree(cls_mall.rule);
NL_SET_ERR_MSG_MOD(cls_mall.common.extack,
"Failed to setup flow action");
return add && tc_skip_sw(head->flags) ? err : 0; return add && tc_skip_sw(head->flags) ? err : 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment