Commit 0cbe8c87 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by John W. Linville

hostap: do not return positive number on failure path in prism2_open()

prism2_open() as an .ndo_open handler should not return positive numbers
in case of failure, but it does return 1 in a couple of places.

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 84893817
...@@ -667,7 +667,7 @@ static int prism2_open(struct net_device *dev) ...@@ -667,7 +667,7 @@ static int prism2_open(struct net_device *dev)
if (local->no_pri) { if (local->no_pri) {
printk(KERN_DEBUG "%s: could not set interface UP - no PRI " printk(KERN_DEBUG "%s: could not set interface UP - no PRI "
"f/w\n", dev->name); "f/w\n", dev->name);
return 1; return -ENODEV;
} }
if ((local->func->card_present && !local->func->card_present(local)) || if ((local->func->card_present && !local->func->card_present(local)) ||
...@@ -682,7 +682,7 @@ static int prism2_open(struct net_device *dev) ...@@ -682,7 +682,7 @@ static int prism2_open(struct net_device *dev)
printk(KERN_WARNING "%s: could not enable MAC port\n", printk(KERN_WARNING "%s: could not enable MAC port\n",
dev->name); dev->name);
prism2_close(dev); prism2_close(dev);
return 1; return -ENODEV;
} }
if (!local->dev_enabled) if (!local->dev_enabled)
prism2_callback(local, PRISM2_CALLBACK_ENABLE); prism2_callback(local, PRISM2_CALLBACK_ENABLE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment