Commit 0ccaa6de authored by Christian Gromm's avatar Christian Gromm Committed by Greg Kroah-Hartman

staging: most: remove redundant call to wake_up_interruptible

This patch prevents the cdev module from rousing the channel wait queue in
case the channel is about to be closed. It is safe to do so, because the
application can not be waiting within read or write and at the same time
be calling close.
Signed-off-by: default avatarChristian Gromm <christian.gromm@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 61f6bfcb
...@@ -127,7 +127,6 @@ static int aim_close(struct inode *inode, struct file *filp) ...@@ -127,7 +127,6 @@ static int aim_close(struct inode *inode, struct file *filp)
kfifo_free(&channel->fifo); kfifo_free(&channel->fifo);
list_del(&channel->list); list_del(&channel->list);
ida_simple_remove(&minor_id, MINOR(channel->devno)); ida_simple_remove(&minor_id, MINOR(channel->devno));
wake_up_interruptible(&channel->wq);
kfree(channel); kfree(channel);
return 0; return 0;
} }
...@@ -139,7 +138,6 @@ static int aim_close(struct inode *inode, struct file *filp) ...@@ -139,7 +138,6 @@ static int aim_close(struct inode *inode, struct file *filp)
most_put_mbo(channel->stacked_mbo); most_put_mbo(channel->stacked_mbo);
ret = most_stop_channel(channel->iface, channel->channel_id, &cdev_aim); ret = most_stop_channel(channel->iface, channel->channel_id, &cdev_aim);
atomic_dec(&channel->access_ref); atomic_dec(&channel->access_ref);
wake_up_interruptible(&channel->wq);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment