Commit 0ccea221 authored by Bhumika Goyal's avatar Bhumika Goyal Committed by David S. Miller

qlogic: qlcnic_sysfs: constify bin_attribute structures

Declare bin_attribute structures as const as they are only passed as an
arguments to the functions device_remove_bin_file and
device_create_bin_file. These function arguments are of type const, so
bin_attribute structures having this property can be made const too.
Done using Coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct bin_attribute i@p = {...};

@ok1@
identifier r1.i;
position p,p1;
@@
(
device_remove_bin_file(...,&i@p)
|
device_create_bin_file(..., &i@p1)
)

@bad@
position p!={r1.p,ok1.p,ok1.p1};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct bin_attribute i;
Signed-off-by: default avatarBhumika Goyal <bhumirks@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a577ca6b
...@@ -1192,56 +1192,56 @@ static struct device_attribute dev_attr_beacon = { ...@@ -1192,56 +1192,56 @@ static struct device_attribute dev_attr_beacon = {
.store = qlcnic_store_beacon, .store = qlcnic_store_beacon,
}; };
static struct bin_attribute bin_attr_crb = { static const struct bin_attribute bin_attr_crb = {
.attr = {.name = "crb", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "crb", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_crb, .read = qlcnic_sysfs_read_crb,
.write = qlcnic_sysfs_write_crb, .write = qlcnic_sysfs_write_crb,
}; };
static struct bin_attribute bin_attr_mem = { static const struct bin_attribute bin_attr_mem = {
.attr = {.name = "mem", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "mem", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_mem, .read = qlcnic_sysfs_read_mem,
.write = qlcnic_sysfs_write_mem, .write = qlcnic_sysfs_write_mem,
}; };
static struct bin_attribute bin_attr_npar_config = { static const struct bin_attribute bin_attr_npar_config = {
.attr = {.name = "npar_config", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "npar_config", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_npar_config, .read = qlcnic_sysfs_read_npar_config,
.write = qlcnic_sysfs_write_npar_config, .write = qlcnic_sysfs_write_npar_config,
}; };
static struct bin_attribute bin_attr_pci_config = { static const struct bin_attribute bin_attr_pci_config = {
.attr = {.name = "pci_config", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "pci_config", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_pci_config, .read = qlcnic_sysfs_read_pci_config,
.write = NULL, .write = NULL,
}; };
static struct bin_attribute bin_attr_port_stats = { static const struct bin_attribute bin_attr_port_stats = {
.attr = {.name = "port_stats", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "port_stats", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_get_port_stats, .read = qlcnic_sysfs_get_port_stats,
.write = qlcnic_sysfs_clear_port_stats, .write = qlcnic_sysfs_clear_port_stats,
}; };
static struct bin_attribute bin_attr_esw_stats = { static const struct bin_attribute bin_attr_esw_stats = {
.attr = {.name = "esw_stats", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "esw_stats", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_get_esw_stats, .read = qlcnic_sysfs_get_esw_stats,
.write = qlcnic_sysfs_clear_esw_stats, .write = qlcnic_sysfs_clear_esw_stats,
}; };
static struct bin_attribute bin_attr_esw_config = { static const struct bin_attribute bin_attr_esw_config = {
.attr = {.name = "esw_config", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "esw_config", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_esw_config, .read = qlcnic_sysfs_read_esw_config,
.write = qlcnic_sysfs_write_esw_config, .write = qlcnic_sysfs_write_esw_config,
}; };
static struct bin_attribute bin_attr_pm_config = { static const struct bin_attribute bin_attr_pm_config = {
.attr = {.name = "pm_config", .mode = (S_IRUGO | S_IWUSR)}, .attr = {.name = "pm_config", .mode = (S_IRUGO | S_IWUSR)},
.size = 0, .size = 0,
.read = qlcnic_sysfs_read_pm_config, .read = qlcnic_sysfs_read_pm_config,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment