Commit 0df125d0 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()

m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6ae5cbc4
...@@ -679,7 +679,7 @@ static int m88e1116r_config_init(struct phy_device *phydev) ...@@ -679,7 +679,7 @@ static int m88e1116r_config_init(struct phy_device *phydev)
if (err < 0) if (err < 0)
return err; return err;
mdelay(500); msleep(500);
err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
if (err < 0) if (err < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment