Commit 0e47c99d authored by Eric W. Biederman's avatar Eric W. Biederman

sysctl: Replace root_list with links between sysctl_table_sets.

Piecing together directories by looking first in one directory
tree, than in another directory tree and finally in a third
directory tree makes it hard to verify that some directory
entries are not multiply defined and makes it hard to create
efficient implementations the sysctl filesystem.

Replace the sysctl wide list of roots with autogenerated
links from the core sysctl directory tree to the other
sysctl directory trees.

This simplifies sysctl directory reading and lookups as now
only entries in a single sysctl directory tree need to be
considered.

Benchmark before:
    make-dummies 0 999 -> 0.44s
    rmmod dummy        -> 0.065s
    make-dummies 0 9999 -> 1m36s
    rmmod dummy         -> 0.4s

Benchmark after:
    make-dummies 0 999 -> 0.63s
    rmmod dummy        -> 0.12s
    make-dummies 0 9999 -> 2m35s
    rmmod dummy         -> 18s

The slowdown is caused by the lookups used in insert_headers
and put_links to see if we need to add links or remove links.
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 6980128f
This diff is collapsed.
...@@ -1051,12 +1051,11 @@ struct ctl_dir { ...@@ -1051,12 +1051,11 @@ struct ctl_dir {
struct ctl_table_set { struct ctl_table_set {
struct list_head list; struct list_head list;
struct ctl_table_root *root;
int (*is_seen)(struct ctl_table_set *); int (*is_seen)(struct ctl_table_set *);
struct ctl_dir dir;
}; };
struct ctl_table_root { struct ctl_table_root {
struct list_head root_list;
struct ctl_table_set default_set; struct ctl_table_set default_set;
struct ctl_table_set *(*lookup)(struct ctl_table_root *root, struct ctl_table_set *(*lookup)(struct ctl_table_root *root,
struct nsproxy *namespaces); struct nsproxy *namespaces);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment