Commit 0e83f46d authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: gma500: fix some swapped gotos

These gotos were swapped.  In the original code, the first would result
in a NULL dereference and the second would result in a memory leak.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1f2b472c
...@@ -460,7 +460,7 @@ static int psbfb_create(struct psb_fbdev *fbdev, ...@@ -460,7 +460,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
if (!fb) { if (!fb) {
DRM_ERROR("failed to allocate fb.\n"); DRM_ERROR("failed to allocate fb.\n");
ret = -ENOMEM; ret = -ENOMEM;
goto out_err0; goto out_err1;
} }
psbfb = to_psb_fb(fb); psbfb = to_psb_fb(fb);
psbfb->size = size; psbfb->size = size;
...@@ -468,7 +468,7 @@ static int psbfb_create(struct psb_fbdev *fbdev, ...@@ -468,7 +468,7 @@ static int psbfb_create(struct psb_fbdev *fbdev,
info = framebuffer_alloc(sizeof(struct psb_fbdev), device); info = framebuffer_alloc(sizeof(struct psb_fbdev), device);
if (!info) { if (!info) {
ret = -ENOMEM; ret = -ENOMEM;
goto out_err1; goto out_err0;
} }
info->par = fbdev; info->par = fbdev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment