Commit 0e8b9f25 authored by Zongmin Zhou's avatar Zongmin Zhou Committed by Maxime Ripard

drm/qxl: prevent memory leak

The allocated memory for qdev->dumb_heads should be released
in qxl_destroy_monitors_object before qxl suspend.
otherwise,qxl_create_monitors_object will be called to
reallocate memory for qdev->dumb_heads after qxl resume,
it will cause memory leak.
Signed-off-by: default avatarZongmin Zhou <zhouzongmin@kylinos.cn>
Link: https://lore.kernel.org/r/20230801025309.4049813-1-zhouzongmin@kylinos.cnReviewed-by: default avatarDave Airlie <airlied@redhat.com>
Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 101c9f63
...@@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev) ...@@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct qxl_device *qdev)
if (!qdev->monitors_config_bo) if (!qdev->monitors_config_bo)
return 0; return 0;
kfree(qdev->dumb_heads);
qdev->dumb_heads = NULL;
qdev->monitors_config = NULL; qdev->monitors_config = NULL;
qdev->ram_header->monitors_config = 0; qdev->ram_header->monitors_config = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment