Commit 0ec6937e authored by Colin Ian King's avatar Colin Ian King Committed by Jens Axboe

lightnvm: pblk: fix resource leak of invalid_bitmap

Currently the error exit path when the emeta could not be
interpreted is via fail_free_ws and this fails to free
invalid_bitmap.  Fix this by adding another exit label and
exiting via this to kfree invalid_bitmap.

Detected by CoverityScan, CID#1469659 ("Resource leak")

Fixes: 48b8d208 ("lightnvm: pblk: garbage collect lines with failed writes")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 21ff1399
...@@ -203,7 +203,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) ...@@ -203,7 +203,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
if (!lba_list) { if (!lba_list) {
pr_err("pblk: could not interpret emeta (line %d)\n", pr_err("pblk: could not interpret emeta (line %d)\n",
line->id); line->id);
goto fail_free_ws; goto fail_free_invalid_bitmap;
} }
} }
...@@ -280,6 +280,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) ...@@ -280,6 +280,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
kfree(gc_rq); kfree(gc_rq);
fail_free_lba_list: fail_free_lba_list:
pblk_mfree(lba_list, l_mg->emeta_alloc_type); pblk_mfree(lba_list, l_mg->emeta_alloc_type);
fail_free_invalid_bitmap:
kfree(invalid_bitmap); kfree(invalid_bitmap);
fail_free_ws: fail_free_ws:
kfree(line_ws); kfree(line_ws);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment