Commit 0edcc47c authored by Bryant G. Ly's avatar Bryant G. Ly Committed by Greg Kroah-Hartman

ibmvscsis: Fix srp_transfer_data fail return code

commit 7c9d8d0c upstream.

If srp_transfer_data fails within ibmvscsis_write_pending, then
the most likely scenario is that the client timed out the op and
removed the TCE mapping. Thus it will loop forever retrying the
op that is pretty much guaranteed to fail forever. A better return
code would be EIO instead of EAGAIN.
Reported-by: default avatarSteven Royer <seroyer@linux.vnet.ibm.com>
Tested-by: default avatarSteven Royer <seroyer@linux.vnet.ibm.com>
Signed-off-by: default avatarBryant G. Ly <bgly@us.ibm.com>
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ba04d869
...@@ -3702,7 +3702,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd) ...@@ -3702,7 +3702,7 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
1, 1); 1, 1);
if (rc) { if (rc) {
pr_err("srp_transfer_data() failed: %d\n", rc); pr_err("srp_transfer_data() failed: %d\n", rc);
return -EAGAIN; return -EIO;
} }
/* /*
* We now tell TCM to add this WRITE CDB directly into the TCM storage * We now tell TCM to add this WRITE CDB directly into the TCM storage
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment