Commit 0f029008 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Greg Kroah-Hartman

usb: isp1760: Replace mdelay with msleep in isp1760_init_core

isp1760_init_core() is never called in atomic context.

The call chains ending up at isp1760_init_core() are:
[1] isp1760_init_core() <- isp1760_register() <- isp1760_plat_probe()
[2] isp1760_init_core() <- isp1760_register() <- isp1761_pci_probe()

isp1760_plat_probe() is set as ".probe" in struct platform_driver.
isp1761_pci_probe() is set as ".probe" in struct pci_driver.
These functions are not called in atomic context.

Despite never getting called from atomic context, isp1761_pci_probe()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2a3dae10
...@@ -31,7 +31,7 @@ static void isp1760_init_core(struct isp1760_device *isp) ...@@ -31,7 +31,7 @@ static void isp1760_init_core(struct isp1760_device *isp)
/* Low-level chip reset */ /* Low-level chip reset */
if (isp->rst_gpio) { if (isp->rst_gpio) {
gpiod_set_value_cansleep(isp->rst_gpio, 1); gpiod_set_value_cansleep(isp->rst_gpio, 1);
mdelay(50); msleep(50);
gpiod_set_value_cansleep(isp->rst_gpio, 0); gpiod_set_value_cansleep(isp->rst_gpio, 0);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment