Commit 0f108ae4 authored by David Ahern's avatar David Ahern Committed by David S. Miller

selftests: Fix raw socket bind tests with VRF

Commit referenced below added negative socket bind tests for VRF. The
socket binds should fail since the address to bind to is in a VRF yet
the socket is not bound to the VRF or a device within it. Update the
expected return code to check for 1 (bind failure) so the test passes
when the bind fails as expected. Add a 'show_hint' comment to explain
why the bind is expected to fail.

Fixes: 75b2b2b3 ("selftests: Add ipv4 address bind tests to fcnal-test")
Reported-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7e014759
...@@ -1810,8 +1810,9 @@ ipv4_addr_bind_vrf() ...@@ -1810,8 +1810,9 @@ ipv4_addr_bind_vrf()
for a in ${NSA_IP} ${VRF_IP} for a in ${NSA_IP} ${VRF_IP}
do do
log_start log_start
show_hint "Socket not bound to VRF, but address is in VRF"
run_cmd nettest -s -R -P icmp -l ${a} -b run_cmd nettest -s -R -P icmp -l ${a} -b
log_test_addr ${a} $? 0 "Raw socket bind to local address" log_test_addr ${a} $? 1 "Raw socket bind to local address"
log_start log_start
run_cmd nettest -s -R -P icmp -l ${a} -I ${NSA_DEV} -b run_cmd nettest -s -R -P icmp -l ${a} -I ${NSA_DEV} -b
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment