Commit 0f113b81 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

net: axienet: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3d2232f5
...@@ -1501,6 +1501,7 @@ static int axienet_of_probe(struct platform_device *op) ...@@ -1501,6 +1501,7 @@ static int axienet_of_probe(struct platform_device *op)
lp->regs = of_iomap(op->dev.of_node, 0); lp->regs = of_iomap(op->dev.of_node, 0);
if (!lp->regs) { if (!lp->regs) {
dev_err(&op->dev, "could not map Axi Ethernet regs.\n"); dev_err(&op->dev, "could not map Axi Ethernet regs.\n");
ret = -ENOMEM;
goto nodev; goto nodev;
} }
/* Setup checksum offload, but default to off if not specified */ /* Setup checksum offload, but default to off if not specified */
...@@ -1563,6 +1564,7 @@ static int axienet_of_probe(struct platform_device *op) ...@@ -1563,6 +1564,7 @@ static int axienet_of_probe(struct platform_device *op)
np = of_parse_phandle(op->dev.of_node, "axistream-connected", 0); np = of_parse_phandle(op->dev.of_node, "axistream-connected", 0);
if (!np) { if (!np) {
dev_err(&op->dev, "could not find DMA node\n"); dev_err(&op->dev, "could not find DMA node\n");
ret = -ENODEV;
goto err_iounmap; goto err_iounmap;
} }
lp->dma_regs = of_iomap(np, 0); lp->dma_regs = of_iomap(np, 0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment