Commit 1037e4c5 authored by Kirill A. Shutemov's avatar Kirill A. Shutemov Committed by Borislav Petkov (AMD)

cpu/hotplug: Add support for declaring CPU offlining not supported

The ACPI MADT mailbox wakeup method doesn't allow to offline a CPU after
it has been woken up.

Currently, offlining is prevented based on the confidential computing attribute
which is set for Intel TDX. But TDX is not the only possible user of the wake up
method. The MADT wakeup can be implemented outside of a confidential computing
environment. Offline support is a property of the wakeup method, not the CoCo
implementation.

Introduce cpu_hotplug_disable_offlining() that can be called to indicate that
CPU offlining should be disabled.

This function is going to replace CC_ATTR_HOTPLUG_DISABLED for ACPI MADT wakeup
method.
Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarTao Liu <ltao@redhat.com>
Link: https://lore.kernel.org/r/20240614095904.1345461-4-kirill.shutemov@linux.intel.com
parent 24dd05da
...@@ -21,6 +21,7 @@ void cpus_read_lock(void); ...@@ -21,6 +21,7 @@ void cpus_read_lock(void);
void cpus_read_unlock(void); void cpus_read_unlock(void);
int cpus_read_trylock(void); int cpus_read_trylock(void);
void lockdep_assert_cpus_held(void); void lockdep_assert_cpus_held(void);
void cpu_hotplug_disable_offlining(void);
void cpu_hotplug_disable(void); void cpu_hotplug_disable(void);
void cpu_hotplug_enable(void); void cpu_hotplug_enable(void);
void clear_tasks_mm_cpumask(int cpu); void clear_tasks_mm_cpumask(int cpu);
...@@ -36,6 +37,7 @@ static inline void cpus_read_lock(void) { } ...@@ -36,6 +37,7 @@ static inline void cpus_read_lock(void) { }
static inline void cpus_read_unlock(void) { } static inline void cpus_read_unlock(void) { }
static inline int cpus_read_trylock(void) { return true; } static inline int cpus_read_trylock(void) { return true; }
static inline void lockdep_assert_cpus_held(void) { } static inline void lockdep_assert_cpus_held(void) { }
static inline void cpu_hotplug_disable_offlining(void) { }
static inline void cpu_hotplug_disable(void) { } static inline void cpu_hotplug_disable(void) { }
static inline void cpu_hotplug_enable(void) { } static inline void cpu_hotplug_enable(void) { }
static inline int remove_cpu(unsigned int cpu) { return -EPERM; } static inline int remove_cpu(unsigned int cpu) { return -EPERM; }
......
...@@ -483,6 +483,8 @@ static int cpu_hotplug_disabled; ...@@ -483,6 +483,8 @@ static int cpu_hotplug_disabled;
DEFINE_STATIC_PERCPU_RWSEM(cpu_hotplug_lock); DEFINE_STATIC_PERCPU_RWSEM(cpu_hotplug_lock);
static bool cpu_hotplug_offline_disabled __ro_after_init;
void cpus_read_lock(void) void cpus_read_lock(void)
{ {
percpu_down_read(&cpu_hotplug_lock); percpu_down_read(&cpu_hotplug_lock);
...@@ -542,6 +544,14 @@ static void lockdep_release_cpus_lock(void) ...@@ -542,6 +544,14 @@ static void lockdep_release_cpus_lock(void)
rwsem_release(&cpu_hotplug_lock.dep_map, _THIS_IP_); rwsem_release(&cpu_hotplug_lock.dep_map, _THIS_IP_);
} }
/* Declare CPU offlining not supported */
void cpu_hotplug_disable_offlining(void)
{
cpu_maps_update_begin();
cpu_hotplug_offline_disabled = true;
cpu_maps_update_done();
}
/* /*
* Wait for currently running CPU hotplug operations to complete (if any) and * Wait for currently running CPU hotplug operations to complete (if any) and
* disable future CPU hotplug (from sysfs). The 'cpu_add_remove_lock' protects * disable future CPU hotplug (from sysfs). The 'cpu_add_remove_lock' protects
...@@ -1471,7 +1481,8 @@ static int cpu_down_maps_locked(unsigned int cpu, enum cpuhp_state target) ...@@ -1471,7 +1481,8 @@ static int cpu_down_maps_locked(unsigned int cpu, enum cpuhp_state target)
* If the platform does not support hotplug, report it explicitly to * If the platform does not support hotplug, report it explicitly to
* differentiate it from a transient offlining failure. * differentiate it from a transient offlining failure.
*/ */
if (cc_platform_has(CC_ATTR_HOTPLUG_DISABLED)) if (cc_platform_has(CC_ATTR_HOTPLUG_DISABLED) ||
cpu_hotplug_offline_disabled)
return -EOPNOTSUPP; return -EOPNOTSUPP;
if (cpu_hotplug_disabled) if (cpu_hotplug_disabled)
return -EBUSY; return -EBUSY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment