Commit 1051da2c authored by Guido Günther's avatar Guido Günther Committed by Pavel

leds: lm3692x: Print error value on dev_err

This gives a way better idea what is going on.
Signed-off-by: default avatarGuido Günther <agx@sigxcpu.org>
Reviewed-by: default avatarDan Murphy <dmurphy@ti.com>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 5b4b723c
...@@ -174,19 +174,20 @@ static int lm3692x_brightness_set(struct led_classdev *led_cdev, ...@@ -174,19 +174,20 @@ static int lm3692x_brightness_set(struct led_classdev *led_cdev,
ret = lm3692x_fault_check(led); ret = lm3692x_fault_check(led);
if (ret) { if (ret) {
dev_err(&led->client->dev, "Cannot read/clear faults\n"); dev_err(&led->client->dev, "Cannot read/clear faults: %d\n",
ret);
goto out; goto out;
} }
ret = regmap_write(led->regmap, LM3692X_BRT_MSB, brt_val); ret = regmap_write(led->regmap, LM3692X_BRT_MSB, brt_val);
if (ret) { if (ret) {
dev_err(&led->client->dev, "Cannot write MSB\n"); dev_err(&led->client->dev, "Cannot write MSB: %d\n", ret);
goto out; goto out;
} }
ret = regmap_write(led->regmap, LM3692X_BRT_LSB, led_brightness_lsb); ret = regmap_write(led->regmap, LM3692X_BRT_LSB, led_brightness_lsb);
if (ret) { if (ret) {
dev_err(&led->client->dev, "Cannot write LSB\n"); dev_err(&led->client->dev, "Cannot write LSB: %d\n", ret);
goto out; goto out;
} }
out: out:
...@@ -203,7 +204,7 @@ static int lm3692x_init(struct lm3692x_led *led) ...@@ -203,7 +204,7 @@ static int lm3692x_init(struct lm3692x_led *led)
ret = regulator_enable(led->regulator); ret = regulator_enable(led->regulator);
if (ret) { if (ret) {
dev_err(&led->client->dev, dev_err(&led->client->dev,
"Failed to enable regulator\n"); "Failed to enable regulator: %d\n", ret);
return ret; return ret;
} }
} }
...@@ -213,7 +214,8 @@ static int lm3692x_init(struct lm3692x_led *led) ...@@ -213,7 +214,8 @@ static int lm3692x_init(struct lm3692x_led *led)
ret = lm3692x_fault_check(led); ret = lm3692x_fault_check(led);
if (ret) { if (ret) {
dev_err(&led->client->dev, "Cannot read/clear faults\n"); dev_err(&led->client->dev, "Cannot read/clear faults: %d\n",
ret);
goto out; goto out;
} }
...@@ -409,7 +411,8 @@ static int lm3692x_remove(struct i2c_client *client) ...@@ -409,7 +411,8 @@ static int lm3692x_remove(struct i2c_client *client)
ret = regmap_update_bits(led->regmap, LM3692X_EN, LM3692X_DEVICE_EN, 0); ret = regmap_update_bits(led->regmap, LM3692X_EN, LM3692X_DEVICE_EN, 0);
if (ret) { if (ret) {
dev_err(&led->client->dev, "Failed to disable regulator\n"); dev_err(&led->client->dev, "Failed to disable regulator: %d\n",
ret);
return ret; return ret;
} }
...@@ -420,7 +423,7 @@ static int lm3692x_remove(struct i2c_client *client) ...@@ -420,7 +423,7 @@ static int lm3692x_remove(struct i2c_client *client)
ret = regulator_disable(led->regulator); ret = regulator_disable(led->regulator);
if (ret) if (ret)
dev_err(&led->client->dev, dev_err(&led->client->dev,
"Failed to disable regulator\n"); "Failed to disable regulator: %d\n", ret);
} }
mutex_destroy(&led->lock); mutex_destroy(&led->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment