Commit 10cdfe54 authored by Tomeu Vizoso's avatar Tomeu Vizoso Committed by Michael Turquette

clk: Don't try to use a struct clk* after it could have been freed

As __clk_release could call kfree on clk and then we wouldn't have a safe way
of getting the module that owns the clock.
Signed-off-by: default avatarTomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: fcb0ee6a ("clk: Implement clk_unregister")
Reviewed-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarMichael Turquette <mturquette@linaro.org>
parent 4afbe176
...@@ -2268,14 +2268,17 @@ int __clk_get(struct clk *clk) ...@@ -2268,14 +2268,17 @@ int __clk_get(struct clk *clk)
void __clk_put(struct clk *clk) void __clk_put(struct clk *clk)
{ {
struct module *owner;
if (!clk || WARN_ON_ONCE(IS_ERR(clk))) if (!clk || WARN_ON_ONCE(IS_ERR(clk)))
return; return;
clk_prepare_lock(); clk_prepare_lock();
owner = clk->owner;
kref_put(&clk->ref, __clk_release); kref_put(&clk->ref, __clk_release);
clk_prepare_unlock(); clk_prepare_unlock();
module_put(clk->owner); module_put(owner);
} }
/*** clk rate change notifiers ***/ /*** clk rate change notifiers ***/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment