Commit 10f129cb authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Steven Rostedt (VMware)

tracing/kprobe: Fix uninitialized variable bug

There is a potential execution path in which variable *ret* is returned
without being properly initialized, previously.

Fix this by initializing variable *ret* to 0.

Link: http://lkml.kernel.org/r/20200205223404.GA3379@embeddedor

Addresses-Coverity-ID: 1491142 ("Uninitialized scalar variable")
Fixes: 2a588dd1 ("tracing: Add kprobe event command generation functions")
Reviewed-by: default avatarTom Zanussi <zanussi@kernel.org>
Acked-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 26445f98
...@@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct dynevent_cmd *cmd, ...) ...@@ -1012,7 +1012,7 @@ int __kprobe_event_add_fields(struct dynevent_cmd *cmd, ...)
{ {
struct dynevent_arg arg; struct dynevent_arg arg;
va_list args; va_list args;
int ret; int ret = 0;
if (cmd->type != DYNEVENT_TYPE_KPROBE) if (cmd->type != DYNEVENT_TYPE_KPROBE)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment