[PATCH] Missing copy_from_user check in comx driver

115bbb11 · Dave Jones · Linus Torvalds · bd3fda33 · 115bbb11
Commit 115bbb11 authored Aug 13, 2003 by Dave Jones Committed by Linus Torvalds Aug 13, 2003
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

drivers/net/wan/comx-hw-locomx.c drivers/net/wan/comx-hw-locomx.c +4 -1

No files found.
--- a/drivers/net/wan/comx-hw-locomx.c
+++ b/drivers/net/wan/comx-hw-locomx.c
@@ -339,7 +339,10 @@ static int locomx_write_proc(struct file *file, const char *buffer,
 		return -ENOMEM;
 	}

-	copy_from_user(page, buffer, count = min_t(unsigned long, count, PAGE_SIZE));
+	if (copy_from_user(page, buffer, count = min_t(unsigned long, count, PAGE_SIZE))) {
+		free_page((unsigned long)page);
+		return -EBADF;
+	}
 	if (*(page + count - 1) == '\n') {
 		*(page + count - 1) = 0;
 	}