Commit 118b7ee1 authored by Jing Yangyang's avatar Jing Yangyang Committed by Linus Torvalds

coda: use vmemdup_user to replace the open code

vmemdup_user is better than duplicating its implementation, So just
replace the open code.

  fs/coda/psdev.c:125:10-18:WARNING:opportunity for vmemdup_user

The issue is detected with the help of Coccinelle.

Link: https://lkml.kernel.org/r/20210908140308.18491-9-jaharkes@cs.cmu.eduReported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarJing Yangyang <jing.yangyang@zte.com.cn>
Signed-off-by: default avatarJan Harkes <jaharkes@cs.cmu.edu>
Cc: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Xin Tan <tanxin.ctf@gmail.com>
Cc: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1077c285
...@@ -122,14 +122,10 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf, ...@@ -122,14 +122,10 @@ static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
hdr.opcode, hdr.unique); hdr.opcode, hdr.unique);
nbytes = size; nbytes = size;
} }
dcbuf = kvmalloc(nbytes, GFP_KERNEL);
if (!dcbuf) { dcbuf = vmemdup_user(buf, nbytes);
retval = -ENOMEM; if (IS_ERR(dcbuf)) {
goto out; retval = PTR_ERR(dcbuf);
}
if (copy_from_user(dcbuf, buf, nbytes)) {
kvfree(dcbuf);
retval = -EFAULT;
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment