Commit 123d5c01 authored by Chris Wilson's avatar Chris Wilson

drm/i915/sdvo: Cleanup connector on error path

We weren't unlinking the freed connector from the drm lists, and so
hit some use-after-free if we failed to initialise the connector.
Reported-and-tested-by: default avatarWoody Suwalski <terraluna977@gmail.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=18342Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 9b74f734
...@@ -2170,8 +2170,7 @@ intel_sdvo_tv_init(struct intel_sdvo *intel_sdvo, int type) ...@@ -2170,8 +2170,7 @@ intel_sdvo_tv_init(struct intel_sdvo *intel_sdvo, int type)
return true; return true;
err: err:
intel_sdvo_destroy_enhance_property(connector); intel_sdvo_destroy(connector);
kfree(intel_sdvo_connector);
return false; return false;
} }
...@@ -2243,8 +2242,7 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device) ...@@ -2243,8 +2242,7 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
return true; return true;
err: err:
intel_sdvo_destroy_enhance_property(connector); intel_sdvo_destroy(connector);
kfree(intel_sdvo_connector);
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment