Commit 1253e974 authored by Gerd Knorr's avatar Gerd Knorr Committed by Linus Torvalds

[PATCH] DVB: No signal with bt848/tda9887

Markus Trippelsdorf reported a non-working bt848 card with the recent
DVB update. 

It's an initialization order bug which changes the default state of the
tda9887 output ports.

Verified to fix the problem by Markus Trippelsdorf <markus@trippelsdorf.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent d49452ab
...@@ -305,9 +305,9 @@ static void dump_write_message(unsigned char *buf) ...@@ -305,9 +305,9 @@ static void dump_write_message(unsigned char *buf)
printk(" B5 force mute audio: %s\n", printk(" B5 force mute audio: %s\n",
(buf[1] & 0x20) ? "yes" : "no"); (buf[1] & 0x20) ? "yes" : "no");
printk(" B6 output port 1 : %s\n", printk(" B6 output port 1 : %s\n",
(buf[1] & 0x40) ? "high" : "low"); (buf[1] & 0x40) ? "high (inactive)" : "low (active)");
printk(" B7 output port 2 : %s\n", printk(" B7 output port 2 : %s\n",
(buf[1] & 0x80) ? "high" : "low"); (buf[1] & 0x80) ? "high (inactive)" : "low (active)");
printk(PREFIX "write: byte C 0x%02x\n",buf[2]); printk(PREFIX "write: byte C 0x%02x\n",buf[2]);
printk(" C0-4 top adjustment : %s dB\n", adjust[buf[2] & 0x1f]); printk(" C0-4 top adjustment : %s dB\n", adjust[buf[2] & 0x1f]);
...@@ -545,9 +545,9 @@ static int tda9887_configure(struct tda9887 *t) ...@@ -545,9 +545,9 @@ static int tda9887_configure(struct tda9887 *t)
int rc; int rc;
memset(buf,0,sizeof(buf)); memset(buf,0,sizeof(buf));
tda9887_set_tvnorm(t,buf);
buf[1] |= cOutputPort1Inactive; buf[1] |= cOutputPort1Inactive;
buf[1] |= cOutputPort2Inactive; buf[1] |= cOutputPort2Inactive;
tda9887_set_tvnorm(t,buf);
if (UNSET != t->pinnacle_id) { if (UNSET != t->pinnacle_id) {
tda9887_set_pinnacle(t,buf); tda9887_set_pinnacle(t,buf);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment