Commit 126901ba authored by Daniel Latypov's avatar Daniel Latypov Committed by Shuah Khan

kunit: tool: remove unused imports and variables

We don't run a linter regularly over kunit.py code (the default settings
on most don't like kernel style, e.g. tabs) so some of these imports
didn't get removed when they stopped being used.
Signed-off-by: default avatarDaniel Latypov <dlatypov@google.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 695e2603
...@@ -123,7 +123,7 @@ def _suites_from_test_list(tests: List[str]) -> List[str]: ...@@ -123,7 +123,7 @@ def _suites_from_test_list(tests: List[str]) -> List[str]:
parts = t.split('.', maxsplit=2) parts = t.split('.', maxsplit=2)
if len(parts) != 2: if len(parts) != 2:
raise ValueError(f'internal KUnit error, test name should be of the form "<suite>.<test>", got "{t}"') raise ValueError(f'internal KUnit error, test name should be of the form "<suite>.<test>", got "{t}"')
suite, case = parts suite, _ = parts
if not suites or suites[-1] != suite: if not suites or suites[-1] != suite:
suites.append(suite) suites.append(suite)
return suites return suites
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
from dataclasses import dataclass from dataclasses import dataclass
import re import re
from typing import Dict, Iterable, List, Set, Tuple from typing import Dict, Iterable, List, Tuple
CONFIG_IS_NOT_SET_PATTERN = r'^# CONFIG_(\w+) is not set$' CONFIG_IS_NOT_SET_PATTERN = r'^# CONFIG_(\w+) is not set$'
CONFIG_PATTERN = r'^CONFIG_(\w+)=(\S+|".*")$' CONFIG_PATTERN = r'^CONFIG_(\w+)=(\S+|".*")$'
......
...@@ -18,7 +18,6 @@ import threading ...@@ -18,7 +18,6 @@ import threading
from typing import Iterator, List, Optional, Tuple from typing import Iterator, List, Optional, Tuple
import kunit_config import kunit_config
from kunit_printer import stdout
import qemu_config import qemu_config
KCONFIG_PATH = '.config' KCONFIG_PATH = '.config'
......
...@@ -12,7 +12,6 @@ ...@@ -12,7 +12,6 @@
from __future__ import annotations from __future__ import annotations
from dataclasses import dataclass from dataclasses import dataclass
import re import re
import sys
import textwrap import textwrap
from enum import Enum, auto from enum import Enum, auto
......
...@@ -328,7 +328,7 @@ class KUnitParserTest(unittest.TestCase): ...@@ -328,7 +328,7 @@ class KUnitParserTest(unittest.TestCase):
def test_parse_subtest_header(self): def test_parse_subtest_header(self):
ktap_log = test_data_path('test_parse_subtest_header.log') ktap_log = test_data_path('test_parse_subtest_header.log')
with open(ktap_log) as file: with open(ktap_log) as file:
result = kunit_parser.parse_run_tests(file.readlines()) kunit_parser.parse_run_tests(file.readlines())
self.print_mock.assert_any_call(StrContains('suite (1 subtest)')) self.print_mock.assert_any_call(StrContains('suite (1 subtest)'))
def test_show_test_output_on_failure(self): def test_show_test_output_on_failure(self):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment