Commit 12900bac authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown

ASoC: qcom: q6afe: remove useless assignments

cppcheck warnings:

sound/soc/qcom/qdsp6/q6afe.c:848:25: note: Assignment 'p=NULL',
assigned value is 0
 struct q6afe_port *p = NULL;
                        ^
sound/soc/qcom/qdsp6/q6afe.c:854:7: note: Null pointer dereference
  if (p->token == token) {
      ^
sound/soc/qcom/qdsp6/q6afe.c:939:8: style: Redundant initialization
for 'wait'. The initialized value is overwritten before it is
read. [redundantInitialization]
  wait = &port->wait;
       ^
sound/soc/qcom/qdsp6/q6afe.c:933:26: note: wait is initialized
 wait_queue_head_t *wait = &port->wait;
                         ^
sound/soc/qcom/qdsp6/q6afe.c:939:8: note: wait is overwritten
  wait = &port->wait;
       ^
sound/soc/qcom/qdsp6/q6afe.c:1191:10: style: Redundant initialization
for 'port_id'. The initialized value is overwritten before it is
read. [redundantInitialization]
 port_id = port->id;
         ^
sound/soc/qcom/qdsp6/q6afe.c:1186:14: note: port_id is initialized
 int port_id = port->id;
             ^
sound/soc/qcom/qdsp6/q6afe.c:1191:10: note: port_id is overwritten
 port_id = port->id;
         ^
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20210218222916.89809-5-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 18bcac6e
...@@ -845,7 +845,7 @@ static void q6afe_port_free(struct kref *ref) ...@@ -845,7 +845,7 @@ static void q6afe_port_free(struct kref *ref)
static struct q6afe_port *q6afe_find_port(struct q6afe *afe, int token) static struct q6afe_port *q6afe_find_port(struct q6afe *afe, int token)
{ {
struct q6afe_port *p = NULL; struct q6afe_port *p;
struct q6afe_port *ret = NULL; struct q6afe_port *ret = NULL;
unsigned long flags; unsigned long flags;
...@@ -930,7 +930,7 @@ EXPORT_SYMBOL_GPL(q6afe_get_port_id); ...@@ -930,7 +930,7 @@ EXPORT_SYMBOL_GPL(q6afe_get_port_id);
static int afe_apr_send_pkt(struct q6afe *afe, struct apr_pkt *pkt, static int afe_apr_send_pkt(struct q6afe *afe, struct apr_pkt *pkt,
struct q6afe_port *port, uint32_t rsp_opcode) struct q6afe_port *port, uint32_t rsp_opcode)
{ {
wait_queue_head_t *wait = &port->wait; wait_queue_head_t *wait;
struct aprv2_ibasic_rsp_result_t *result; struct aprv2_ibasic_rsp_result_t *result;
int ret; int ret;
...@@ -1188,7 +1188,6 @@ int q6afe_port_stop(struct q6afe_port *port) ...@@ -1188,7 +1188,6 @@ int q6afe_port_stop(struct q6afe_port *port)
int index, pkt_size; int index, pkt_size;
void *p; void *p;
port_id = port->id;
index = port->token; index = port->token;
if (index < 0 || index >= AFE_PORT_MAX) { if (index < 0 || index >= AFE_PORT_MAX) {
dev_err(afe->dev, "AFE port index[%d] invalid!\n", index); dev_err(afe->dev, "AFE port index[%d] invalid!\n", index);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment