Commit 12aba9e7 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

bnx2i: use strlcpy() instead of memcpy() for strings

DRV_MODULE_VERSION here is "2.7.2.2" which is only 8 chars but we copy
12 bytes from the stack so it's a small information leak.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarMichael Chan <mchan@broadcom.com>
Acked-by: default avatarEddie Wai <eddie.wai@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8f961fae
...@@ -400,7 +400,7 @@ int bnx2i_get_stats(void *handle) ...@@ -400,7 +400,7 @@ int bnx2i_get_stats(void *handle)
if (!stats) if (!stats)
return -ENOMEM; return -ENOMEM;
memcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version)); strlcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version));
memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN); memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN);
stats->max_frame_size = hba->netdev->mtu; stats->max_frame_size = hba->netdev->mtu;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment