Commit 132ea824 authored by Thomas Kuehne's avatar Thomas Kuehne Committed by Jiri Kosina

HID: hid-debug: more informative output for EV_KEY

Currently hid-debug's hid_resolv_event prints questions marks for
all entries without explicit mapping information. This makes
debugging unnecessarily complicated as multiple different
keys may simply result in the same uninformative output.

Some common event codes are deliberately not defined in
input-event-codes.h. For example the 16th gamepad key.

Instead, print the hexadecimal codes for all events without symbolic
names.
Signed-off-by: default avatarThomas Kuehne <thomas.kuehne@gmx.li>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 815234a4
...@@ -3582,8 +3582,15 @@ static const char **names[EV_MAX + 1] = { ...@@ -3582,8 +3582,15 @@ static const char **names[EV_MAX + 1] = {
static void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f) static void hid_resolv_event(__u8 type, __u16 code, struct seq_file *f)
{ {
seq_printf(f, "%s.%s", events[type] ? events[type] : "?", if (events[type])
names[type] ? (names[type][code] ? names[type][code] : "?") : "?"); seq_printf(f, "%s.", events[type]);
else
seq_printf(f, "%02x.", type);
if (names[type] && names[type][code])
seq_printf(f, "%s", names[type][code]);
else
seq_printf(f, "%04x", code);
} }
static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f) static void hid_dump_input_mapping(struct hid_device *hid, struct seq_file *f)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment