[PATCH] e100: early reset fix
Gents, what do we think of the below fix? Thanks. My IBM A21P laptop is getting an IRQ storm at boot. IRQ #11 is shared between USB and e100, and USB is getting in there first. Consequently, when e100 initialises the hardware, that interrupt line is ready to go. As soon as e100.c runs pci_set_master(), the interrupt hits the CPU. But of course the e100 driver isn't ready to handle the interrupt yet, so the system disables IRQ #11. This only happens on warm boots (/sbin/reboot). Things work OK from power-on. So I assume that the BIOS is failing to fully reset the NIC and that some sort of interrupt is internally pending. The patch rearranges e100_probe() so that we issue e100_hw_reset() prior to running pci_set_master(), and fixes the problem. Note that e100_probe() is now running e100_hw_reset() twice - I didn't remove the later call for general paranoia reasons. eepro100.c has the same lockup, and needs a similar fix. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Showing
Please register or sign in to comment