Commit 13eb1e21 authored by Andrew Boyer's avatar Andrew Boyer Committed by Doug Ledford

IB/rxe: Avoid ICRC errors by copying into the skb first

The current process is to first calculate the CRC and then copy the client
data into the packet. This leaves a window in which the packet contents and
CRC can get out of sync, if the client changes the data after the CRC is
calculated but before the data is copied.

By copying the data into the packet and then calculating the CRC directly
from the packet contents we eliminate the window.

This can be seen with qperf's ud_bi_bw test. This seems like very
strange/reckless client behavior, but whether the client has mangled its
data or not RXE should be able to transfer it reliably.

Fixes: 8700e3e7 ("Soft RoCE driver")
Signed-off-by: default avatarAndrew Boyer <andrew.boyer@dell.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 1223a1af
...@@ -367,11 +367,11 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length, ...@@ -367,11 +367,11 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length,
dest = (dir == to_mem_obj) ? dest = (dir == to_mem_obj) ?
((void *)(uintptr_t)iova) : addr; ((void *)(uintptr_t)iova) : addr;
memcpy(dest, src, length);
if (crcp) if (crcp)
*crcp = rxe_crc32(to_rdev(mem->pd->ibpd.device), *crcp = rxe_crc32(to_rdev(mem->pd->ibpd.device),
*crcp, src, length); *crcp, dest, length);
memcpy(dest, src, length);
return 0; return 0;
} }
...@@ -401,11 +401,11 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length, ...@@ -401,11 +401,11 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length,
if (bytes > length) if (bytes > length)
bytes = length; bytes = length;
memcpy(dest, src, bytes);
if (crcp) if (crcp)
crc = rxe_crc32(to_rdev(mem->pd->ibpd.device), crc = rxe_crc32(to_rdev(mem->pd->ibpd.device),
crc, src, bytes); crc, dest, bytes);
memcpy(dest, src, bytes);
length -= bytes; length -= bytes;
addr += bytes; addr += bytes;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment