Commit 14816b16 authored by Johan Hovold's avatar Johan Hovold

USB: serial: console: fix uninitialised spinlock

Since commit 4a510969 ("tty: Make tty_files_lock per-tty") a new
tty_struct spin lock is taken in the tty release path, but the
USB-serial-console hack was never updated hence leaving the lock of its
"fake" tty uninitialised. This was eventually detected by lockdep.

Make sure to initialise the new lock also for the fake tty to address
this regression.

Yes, this code is a mess, but cleaning it up is left for another day.

Fixes: 4a510969 ("tty: Make tty_files_lock per-tty")
Cc: stable <stable@vger.kernel.org>	# 4.6
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent acfe2763
...@@ -143,6 +143,7 @@ static int usb_console_setup(struct console *co, char *options) ...@@ -143,6 +143,7 @@ static int usb_console_setup(struct console *co, char *options)
tty->driver = usb_serial_tty_driver; tty->driver = usb_serial_tty_driver;
tty->index = co->index; tty->index = co->index;
init_ldsem(&tty->ldisc_sem); init_ldsem(&tty->ldisc_sem);
spin_lock_init(&tty->files_lock);
INIT_LIST_HEAD(&tty->tty_files); INIT_LIST_HEAD(&tty->tty_files);
kref_get(&tty->driver->kref); kref_get(&tty->driver->kref);
__module_get(tty->driver->owner); __module_get(tty->driver->owner);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment