Commit 15167554 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Andy Shevchenko

platform/x86: intel_pmc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Cc: Vishwanath Somayaji <vishwanath.somayaji@intel.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent d42c06c4
...@@ -753,14 +753,11 @@ static void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev) ...@@ -753,14 +753,11 @@ static void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev)
debugfs_remove_recursive(pmcdev->dbgfs_dir); debugfs_remove_recursive(pmcdev->dbgfs_dir);
} }
static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) static void pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
{ {
struct dentry *dir; struct dentry *dir;
dir = debugfs_create_dir("pmc_core", NULL); dir = debugfs_create_dir("pmc_core", NULL);
if (!dir)
return -ENOMEM;
pmcdev->dbgfs_dir = dir; pmcdev->dbgfs_dir = dir;
debugfs_create_file("slp_s0_residency_usec", 0444, dir, pmcdev, debugfs_create_file("slp_s0_residency_usec", 0444, dir, pmcdev,
...@@ -794,13 +791,10 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) ...@@ -794,13 +791,10 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
debugfs_create_bool("slp_s0_dbg_latch", 0644, debugfs_create_bool("slp_s0_dbg_latch", 0644,
dir, &slps0_dbg_latch); dir, &slps0_dbg_latch);
} }
return 0;
} }
#else #else
static inline int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) static inline void pmc_core_dbgfs_register(struct pmc_dev *pmcdev)
{ {
return 0;
} }
static inline void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev) static inline void pmc_core_dbgfs_unregister(struct pmc_dev *pmcdev)
...@@ -862,7 +856,6 @@ static int pmc_core_probe(struct platform_device *pdev) ...@@ -862,7 +856,6 @@ static int pmc_core_probe(struct platform_device *pdev)
struct pmc_dev *pmcdev = &pmc; struct pmc_dev *pmcdev = &pmc;
const struct x86_cpu_id *cpu_id; const struct x86_cpu_id *cpu_id;
u64 slp_s0_addr; u64 slp_s0_addr;
int err;
if (device_initialized) if (device_initialized)
return -ENODEV; return -ENODEV;
...@@ -896,12 +889,7 @@ static int pmc_core_probe(struct platform_device *pdev) ...@@ -896,12 +889,7 @@ static int pmc_core_probe(struct platform_device *pdev)
pmcdev->pmc_xram_read_bit = pmc_core_check_read_lock_bit(); pmcdev->pmc_xram_read_bit = pmc_core_check_read_lock_bit();
dmi_check_system(pmc_core_dmi_table); dmi_check_system(pmc_core_dmi_table);
err = pmc_core_dbgfs_register(pmcdev); pmc_core_dbgfs_register(pmcdev);
if (err < 0) {
dev_warn(&pdev->dev, "debugfs register failed.\n");
iounmap(pmcdev->regbase);
return err;
}
device_initialized = true; device_initialized = true;
dev_info(&pdev->dev, " initialized\n"); dev_info(&pdev->dev, " initialized\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment