Commit 15ddb4ae authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by J. Bruce Fields

NFSD: don't report compiled-out versions as present

The /proc/fs/nfsd/versions file calls nfsd_vers() to check whether
the particular nfsd version is present/available. The problem is
that once I turn off e.g. NFSD-V4 this call returns -1 which is
true from the callers POV which is wrong.

The proposal is to report false in that case.

The bug has existed since 6658d3a7 "[PATCH] knfsd: remove
nfsd_versbits as intermediate storage for desired versions".
Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Cc: stable@kernel.org
Acked-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent 4dc6ec00
...@@ -120,7 +120,7 @@ u32 nfsd_supported_minorversion; ...@@ -120,7 +120,7 @@ u32 nfsd_supported_minorversion;
int nfsd_vers(int vers, enum vers_op change) int nfsd_vers(int vers, enum vers_op change)
{ {
if (vers < NFSD_MINVERS || vers >= NFSD_NRVERS) if (vers < NFSD_MINVERS || vers >= NFSD_NRVERS)
return -1; return 0;
switch(change) { switch(change) {
case NFSD_SET: case NFSD_SET:
nfsd_versions[vers] = nfsd_version[vers]; nfsd_versions[vers] = nfsd_version[vers];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment