Commit 165f2cf6 authored by Xin Long's avatar Xin Long Committed by David S. Miller

sctp: reduce indent level in sctp_copy_local_addr_list

This patch is to reduce indent level by using continue when the addr
is not allowed, and also drop end_copy by using break.
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 92f95322
...@@ -205,26 +205,27 @@ int sctp_copy_local_addr_list(struct net *net, struct sctp_bind_addr *bp, ...@@ -205,26 +205,27 @@ int sctp_copy_local_addr_list(struct net *net, struct sctp_bind_addr *bp,
list_for_each_entry_rcu(addr, &net->sctp.local_addr_list, list) { list_for_each_entry_rcu(addr, &net->sctp.local_addr_list, list) {
if (!addr->valid) if (!addr->valid)
continue; continue;
if (sctp_in_scope(net, &addr->a, scope)) { if (!sctp_in_scope(net, &addr->a, scope))
/* Now that the address is in scope, check to see if continue;
* the address type is really supported by the local
* sock as well as the remote peer. /* Now that the address is in scope, check to see if
*/ * the address type is really supported by the local
if ((((AF_INET == addr->a.sa.sa_family) && * sock as well as the remote peer.
(copy_flags & SCTP_ADDR4_PEERSUPP))) || */
(((AF_INET6 == addr->a.sa.sa_family) && if (addr->a.sa.sa_family == AF_INET &&
(copy_flags & SCTP_ADDR6_ALLOWED) && !(copy_flags & SCTP_ADDR4_PEERSUPP))
(copy_flags & SCTP_ADDR6_PEERSUPP)))) { continue;
error = sctp_add_bind_addr(bp, &addr->a, if (addr->a.sa.sa_family == AF_INET6 &&
sizeof(addr->a), (!(copy_flags & SCTP_ADDR6_ALLOWED) ||
SCTP_ADDR_SRC, GFP_ATOMIC); !(copy_flags & SCTP_ADDR6_PEERSUPP)))
if (error) continue;
goto end_copy;
} error = sctp_add_bind_addr(bp, &addr->a, sizeof(addr->a),
} SCTP_ADDR_SRC, GFP_ATOMIC);
if (error)
break;
} }
end_copy:
rcu_read_unlock(); rcu_read_unlock();
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment