Commit 16a29dd3 authored by Andrew Jiang's avatar Andrew Jiang Committed by Alex Deucher

drm/amd/display: Refine update flags usage in update_dchubp_dpp

- Only update DPP clock if it's a full update.
- Program viewport on position change. This caused SLS regressions.
Signed-off-by: default avatarAndrew Jiang <Andrew.Jiang@amd.com>
Reviewed-by: default avatarTony Cheng <Tony.Cheng@amd.com>
Acked-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ea783c31
...@@ -1726,7 +1726,7 @@ static void update_dchubp_dpp( ...@@ -1726,7 +1726,7 @@ static void update_dchubp_dpp(
union plane_size size = plane_state->plane_size; union plane_size size = plane_state->plane_size;
/* depends on DML calculation, DPP clock value may change dynamically */ /* depends on DML calculation, DPP clock value may change dynamically */
if (pipe_ctx->plane_state->update_flags.raw != 0) { if (plane_state->update_flags.bits.full_update) {
enable_dppclk( enable_dppclk(
dc->hwseq, dc->hwseq,
pipe_ctx->pipe_idx, pipe_ctx->pipe_idx,
...@@ -1770,7 +1770,8 @@ static void update_dchubp_dpp( ...@@ -1770,7 +1770,8 @@ static void update_dchubp_dpp(
} }
if (plane_state->update_flags.bits.full_update || if (plane_state->update_flags.bits.full_update ||
plane_state->update_flags.bits.scaling_change) { plane_state->update_flags.bits.scaling_change ||
plane_state->update_flags.bits.position_change) {
hubp->funcs->mem_program_viewport( hubp->funcs->mem_program_viewport(
hubp, hubp,
&pipe_ctx->plane_res.scl_data.viewport, &pipe_ctx->plane_res.scl_data.viewport,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment