Commit 171afcd4 authored by Ivo van Doorn's avatar Ivo van Doorn Committed by John W. Linville

rt2x00: Only free skb when beacon_update fails

In rt2x00lib_intf_scheduled_iter() we use the hw->beacon_update()
callback function. This means that it should behave similarly as mac80211
when that uses the function.

This means that the skb should only be freed when beacon_update() has failed,
otherwise the driver is the owner and is responsible for freeing the buffer.
Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3a245766
...@@ -433,11 +433,9 @@ static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac, ...@@ -433,11 +433,9 @@ static void rt2x00lib_intf_scheduled_iter(void *data, u8 *mac,
if (delayed_flags & DELAYED_UPDATE_BEACON) { if (delayed_flags & DELAYED_UPDATE_BEACON) {
skb = ieee80211_beacon_get(rt2x00dev->hw, vif, &control); skb = ieee80211_beacon_get(rt2x00dev->hw, vif, &control);
if (skb) { if (skb && rt2x00dev->ops->hw->beacon_update(rt2x00dev->hw,
rt2x00dev->ops->hw->beacon_update(rt2x00dev->hw, skb, skb, &control))
&control);
dev_kfree_skb(skb); dev_kfree_skb(skb);
}
} }
if (delayed_flags & DELAYED_CONFIG_ERP) if (delayed_flags & DELAYED_CONFIG_ERP)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment