Commit 17ef20f1 authored by Lee Jones's avatar Lee Jones Committed by Zack Rusin

drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context'
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct vmw_cmdbuf_man '
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:164: warning: Function parameter or member 'handle' not described in 'vmw_cmdbuf_header'
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:257: warning: Function parameter or member 'header' not described in '__vmw_cmdbuf_header_free'
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:380: warning: Function parameter or member 'notempty' not described in 'vmw_cmdbuf_ctx_process'
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1168: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_preempt'
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1193: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_startstop'

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-38-lee.jones@linaro.org
parent ad2ae415
...@@ -48,6 +48,7 @@ ...@@ -48,6 +48,7 @@
* @hw_submitted: List of command buffers submitted to hardware. * @hw_submitted: List of command buffers submitted to hardware.
* @preempted: List of preempted command buffers. * @preempted: List of preempted command buffers.
* @num_hw_submitted: Number of buffers currently being processed by hardware * @num_hw_submitted: Number of buffers currently being processed by hardware
* @block_submission: Identifies a block command submission.
*/ */
struct vmw_cmdbuf_context { struct vmw_cmdbuf_context {
struct list_head submitted; struct list_head submitted;
...@@ -58,7 +59,7 @@ struct vmw_cmdbuf_context { ...@@ -58,7 +59,7 @@ struct vmw_cmdbuf_context {
}; };
/** /**
* struct vmw_cmdbuf_man: - Command buffer manager * struct vmw_cmdbuf_man - Command buffer manager
* *
* @cur_mutex: Mutex protecting the command buffer used for incremental small * @cur_mutex: Mutex protecting the command buffer used for incremental small
* kernel command submissions, @cur. * kernel command submissions, @cur.
...@@ -143,7 +144,7 @@ struct vmw_cmdbuf_man { ...@@ -143,7 +144,7 @@ struct vmw_cmdbuf_man {
* @cb_context: The device command buffer context. * @cb_context: The device command buffer context.
* @list: List head for attaching to the manager lists. * @list: List head for attaching to the manager lists.
* @node: The range manager node. * @node: The range manager node.
* @handle. The DMA address of @cb_header. Handed to the device on command * @handle: The DMA address of @cb_header. Handed to the device on command
* buffer submission. * buffer submission.
* @cmd: Pointer to the command buffer space of this buffer. * @cmd: Pointer to the command buffer space of this buffer.
* @size: Size of the command buffer space of this buffer. * @size: Size of the command buffer space of this buffer.
...@@ -249,7 +250,7 @@ static void vmw_cmdbuf_header_inline_free(struct vmw_cmdbuf_header *header) ...@@ -249,7 +250,7 @@ static void vmw_cmdbuf_header_inline_free(struct vmw_cmdbuf_header *header)
* __vmw_cmdbuf_header_free - Free a struct vmw_cmdbuf_header and its * __vmw_cmdbuf_header_free - Free a struct vmw_cmdbuf_header and its
* associated structures. * associated structures.
* *
* header: Pointer to the header to free. * @header: Pointer to the header to free.
* *
* For internal use. Must be called with man::lock held. * For internal use. Must be called with man::lock held.
*/ */
...@@ -365,10 +366,11 @@ static void vmw_cmdbuf_ctx_submit(struct vmw_cmdbuf_man *man, ...@@ -365,10 +366,11 @@ static void vmw_cmdbuf_ctx_submit(struct vmw_cmdbuf_man *man,
} }
/** /**
* vmw_cmdbuf_ctx_submit: Process a command buffer context. * vmw_cmdbuf_ctx_process - Process a command buffer context.
* *
* @man: The command buffer manager. * @man: The command buffer manager.
* @ctx: The command buffer context. * @ctx: The command buffer context.
* @notempty: Pass back count of non-empty command submitted lists.
* *
* Submit command buffers to hardware if possible, and process finished * Submit command buffers to hardware if possible, and process finished
* buffers. Typically freeing them, but on preemption or error take * buffers. Typically freeing them, but on preemption or error take
...@@ -1161,6 +1163,7 @@ static int vmw_cmdbuf_send_device_command(struct vmw_cmdbuf_man *man, ...@@ -1161,6 +1163,7 @@ static int vmw_cmdbuf_send_device_command(struct vmw_cmdbuf_man *man,
* context. * context.
* *
* @man: The command buffer manager. * @man: The command buffer manager.
* @context: Device context to pass command through.
* *
* Synchronously sends a preempt command. * Synchronously sends a preempt command.
*/ */
...@@ -1184,6 +1187,7 @@ static int vmw_cmdbuf_preempt(struct vmw_cmdbuf_man *man, u32 context) ...@@ -1184,6 +1187,7 @@ static int vmw_cmdbuf_preempt(struct vmw_cmdbuf_man *man, u32 context)
* context. * context.
* *
* @man: The command buffer manager. * @man: The command buffer manager.
* @context: Device context to start/stop.
* @enable: Whether to enable or disable the context. * @enable: Whether to enable or disable the context.
* *
* Synchronously sends a device start / stop context command. * Synchronously sends a device start / stop context command.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment