Commit 1830f893 authored by Jason Wang's avatar Jason Wang Committed by David S. Miller

virtio-net: correctly handle XDP_PASS for linearized packets

When XDP_PASS were determined for linearized packets, we try to get
new buffers in the virtqueue and build skbs from them. This is wrong,
we should create skbs based on existed buffers instead. Fixing them by
creating skb based on xdp_page.

With this patch "ping 192.168.100.4 -s 3900 -M do" works for XDP_PASS.

Cc: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Acked-by: default avatarJohn Fastabend <john.r.fastabend@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56a86f84
...@@ -578,8 +578,14 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, ...@@ -578,8 +578,14 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
act = do_xdp_prog(vi, rq, xdp_prog, xdp_page, offset, len); act = do_xdp_prog(vi, rq, xdp_prog, xdp_page, offset, len);
switch (act) { switch (act) {
case XDP_PASS: case XDP_PASS:
if (unlikely(xdp_page != page)) /* We can only create skb based on xdp_page. */
__free_pages(xdp_page, 0); if (unlikely(xdp_page != page)) {
rcu_read_unlock();
put_page(page);
head_skb = page_to_skb(vi, rq, xdp_page,
0, len, PAGE_SIZE);
return head_skb;
}
break; break;
case XDP_TX: case XDP_TX:
if (unlikely(xdp_page != page)) if (unlikely(xdp_page != page))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment