Commit 186abe7f authored by Chris Brandt's avatar Chris Brandt Committed by Greg Kroah-Hartman

usb: r8a66597-hcd: select a different endpoint on timeout

commit 1f873d85 upstream.

If multiple endpoints on a single device have pending IN URBs and one
endpoint times out due to NAKs (perfectly legal), select a different
endpoint URB to try.
The existing code only checked to see another device address has pending
URBs and ignores other IN endpoints on the current device address. This
leads to endpoints never getting serviced if one endpoint is using NAK as
a flow control method.

Fixes: 5d304358 ("usb: r8a66597-hcd: host controller driver for R8A6659")
Signed-off-by: default avatarChris Brandt <chris.brandt@renesas.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3921a351
...@@ -1785,6 +1785,7 @@ static void r8a66597_td_timer(unsigned long _r8a66597) ...@@ -1785,6 +1785,7 @@ static void r8a66597_td_timer(unsigned long _r8a66597)
pipe = td->pipe; pipe = td->pipe;
pipe_stop(r8a66597, pipe); pipe_stop(r8a66597, pipe);
/* Select a different address or endpoint */
new_td = td; new_td = td;
do { do {
list_move_tail(&new_td->queue, list_move_tail(&new_td->queue,
...@@ -1794,7 +1795,8 @@ static void r8a66597_td_timer(unsigned long _r8a66597) ...@@ -1794,7 +1795,8 @@ static void r8a66597_td_timer(unsigned long _r8a66597)
new_td = td; new_td = td;
break; break;
} }
} while (td != new_td && td->address == new_td->address); } while (td != new_td && td->address == new_td->address &&
td->pipe->info.epnum == new_td->pipe->info.epnum);
start_transfer(r8a66597, new_td); start_transfer(r8a66597, new_td);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment