Commit 186b1da7 authored by Oleksij Rempel's avatar Oleksij Rempel Committed by Paolo Abeni

net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes

Currently, it is possible to let some PHYs to advertise not supported
EEE link modes. So, validate them before overwriting existing
configuration.
Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 3eeca4e1
...@@ -1438,12 +1438,23 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev, ...@@ -1438,12 +1438,23 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
int ret; int ret;
if (data->eee_enabled) { if (data->eee_enabled) {
if (data->advertised) if (data->advertised) {
__ETHTOOL_DECLARE_LINK_MODE_MASK(adv);
ethtool_convert_legacy_u32_to_link_mode(adv,
data->advertised);
linkmode_andnot(adv, adv, phydev->supported_eee);
if (!linkmode_empty(adv)) {
phydev_warn(phydev, "At least some EEE link modes are not supported.\n");
return -EINVAL;
}
ethtool_convert_legacy_u32_to_link_mode(phydev->advertising_eee, ethtool_convert_legacy_u32_to_link_mode(phydev->advertising_eee,
data->advertised); data->advertised);
else } else {
linkmode_copy(phydev->advertising_eee, linkmode_copy(phydev->advertising_eee,
phydev->supported_eee); phydev->supported_eee);
}
phydev->eee_enabled = true; phydev->eee_enabled = true;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment